linux-kernel - Re: [PATCH 2/2] power_supply: Add support for TI BQ25890 charger chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150624083058.GA17732@amd>
Date:	Wed, 24 Jun 2015 10:30:58 +0200
From:	Pavel Machek <pavel@....cz>
To:	Laurentiu Palcu <laurentiu.palcu@...el.com>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Sebastian Reichel <sre@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/2] power_supply: Add support for TI BQ25890 charger chip

On Wed 2015-06-24 10:32:54, Laurentiu Palcu wrote:
> On Sat, May 02, 2015 at 04:59:34PM +0200, Pavel Machek wrote:
> > 
> > Should this link....
> > 
> > > More details about the chip can be found here:
> > > http://www.ti.com/product/bq25890
> > 
> > > @@ -0,0 +1,998 @@
> > > +/*
> > > + * TI BQ25890 charger driver
> > > + *
> > > + * Copyright (C) 2015 Intel Corporation
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation; either version 2 of the License, or
> > > + * (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > + * GNU General Public License for more details.
> > 
> > > + *
> > > + */
> > 
> > Go here?
> Where exactly? Was 'here' supposed to be a hyperlink that, for some
> reason, is missing? Anyway, if you're asking why the link I provided


Put the link to the comment at top of the driver, not into the
changelog.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/