linux-kernel - Re: [PATCH v2] staging: rtl8192u: bool tests don't need comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150624101201.GA30628@goodgumbo.baconseed.org>
Date:	Wed, 24 Jun 2015 12:12:01 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Greg Donald <gdonald@...il.com>,
	Koray Gulcu <koray.gulcu@....edu.tr>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	Karthik Nayak <karthik.188@...il.com>
Subject: Re: [PATCH v2] staging: rtl8192u: bool tests don't need comparisons

On Wed, Jun 24, 2015 at 11:05:16AM +0530, Sudip Mukherjee wrote:
> On Tue, Jun 23, 2015 at 03:10:56PM +0200, Luis de Bethencourt wrote:
> > Remove explicit true/false comparations to bool variables.
> > 
> > Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> > ---
> <snip>
> > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> > index 12dd19e..9946615 100644
> > --- a/drivers/staging/rtl8192u/r8192U_dm.c
> > +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> > @@ -438,7 +438,7 @@ static void dm_bandwidth_autoswitch(struct net_device *dev)
> >  
> >  	if (priv->CurrentChannelBW == HT_CHANNEL_WIDTH_20 || !priv->ieee80211->bandwidth_auto_switch.bautoswitch_enable)
> >  		return;
> > -	if (priv->ieee80211->bandwidth_auto_switch.bforced_tx20Mhz == false) { /* If send packets in 40 Mhz in 20/40 */
> > +	if (!priv->ieee80211->bandwidth_auto_switch.bforced_tx20Mhz) { /* If send packets in 40 Mhz in 20/40 */
> >  		if (priv->undecorated_smoothed_pwdb <= priv->ieee80211->bandwidth_auto_switch.threshold_40Mhzto20Mhz)
> >  			priv->ieee80211->bandwidth_auto_switch.bforced_tx20Mhz = true;
> >  	} else { /* in force send packets in 20 Mhz in 20/40 */
> > @@ -563,7 +563,7 @@ static void dm_TXPowerTrackingCallback_TSSI(struct net_device *dev)
> >  					break;
> >  				}
> >  			}
> > -			if (viviflag == true) {
> > +			if (viviflag) {
> I think you need to refresh your tree. This change has already been done by:
> c40753b5c7ee ("staging: rtl8192u: Removed redundant bool comparisons in r8192U_dm.c")
> 
> regards
> sudip

True. My bad.

I based the patch on staging's master and not on the staging-next branch.

Commit c40753b5c7ee from Harisangam Sharvari doesn't fix all the redundant bool
comparisons in the module. So I have fixed the patch and sent a second version.

I see you are very active reviewing. Thank you very much for your work,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/