linux-kernel - Re: [PATCH] mfd: intel_soc_pmic: Constify ACPI device ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150624105954.GF15013@x1>
Date:	Wed, 24 Jun 2015 11:59:54 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Mathias Krause <minipli@...glemail.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
	"Yang, Bin" <bin.yang@...el.com>,
	"Zhu, Lejun" <lejun.zhu@...ux.intel.com>
Subject: Re: [PATCH] mfd: intel_soc_pmic: Constify ACPI device ids

On Sat, 13 Jun 2015, Mathias Krause wrote:

> Constify the ACPI device ID array, it doesn't need to be writable at
> runtime.
> 
> Signed-off-by: Mathias Krause <minipli@...glemail.com>
> Cc: Yang, Bin <bin.yang@...el.com>
> Cc: Zhu, Lejun <lejun.zhu@...ux.intel.com>
> ---
>  drivers/mfd/intel_soc_pmic_core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied for v4.3, thanks.

> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index 7b50b6b208a5..27e7552a29dd 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -147,7 +147,7 @@ static const struct i2c_device_id intel_soc_pmic_i2c_id[] = {
>  MODULE_DEVICE_TABLE(i2c, intel_soc_pmic_i2c_id);
>  
>  #if defined(CONFIG_ACPI)
> -static struct acpi_device_id intel_soc_pmic_acpi_match[] = {
> +static const struct acpi_device_id intel_soc_pmic_acpi_match[] = {
>  	{"INT33FD", (kernel_ulong_t)&intel_soc_pmic_config_crc},
>  	{ },
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/