linux-kernel - Re: [PATCH 09/17] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150624151257.fe5f1594db1afe4c1da8027d@ti.com>
Date:	Wed, 24 Jun 2015 15:12:57 +0300
From:	Roger Quadros <rogerq@...com>
To:	Roger Quadros <rogerq@...com>
CC:	Kishon Vijay Abraham I <kishon@...com>, <bcousson@...libre.com>,
	<tony@...mide.com>, <balbi@...com>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-usb@...r.kernel.org>, <robh+dt@...nel.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<linux@....linux.org.uk>, <gregkh@...uxfoundation.org>,
	<nsekhar@...com>
Subject: Re: [PATCH 09/17] ARM: dts: dra7: Use "syscon-phy-power" instead of
 "ctrl-module" in SATA PHY node

On Wed, 24 Jun 2015 15:06:02 +0300
Roger Quadros <rogerq@...com> wrote:

> On Tue, 23 Jun 2015 17:28:54 +0530
> Kishon Vijay Abraham I <kishon@...com> wrote:
> 
> > Add "syscon-phy-power" property and remove the deprecated "ctrl-module"
> > property from SATA PHY node. Since "omap_control_sata" note is no longer
> > used, remove it.
> > 
> > Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> 
> Acked-by: Roger Quadros <rogerq@...com>

One comment though.

> 
> > ---
> >  arch/arm/boot/dts/dra7.dtsi |   10 +---------
> >  1 file changed, 1 insertion(+), 9 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> > index 3f434f7..92e0741 100644
> > --- a/arch/arm/boot/dts/dra7.dtsi
> > +++ b/arch/arm/boot/dts/dra7.dtsi
> > @@ -1115,14 +1115,6 @@
> >  			status = "disabled";
> >  		};
> >  
> > -		omap_control_sata: control-phy@...02374 {
> > -			compatible = "ti,control-phy-pipe3";
> > -			reg = <0x4a002374 0x4>;
> > -			reg-names = "power";
> > -			clocks = <&sys_clkin1>;
> > -			clock-names = "sysclk";
> > -		};
> > -
> >  		/* OCP2SCP3 */
> >  		ocp2scp@...90000 {
> >  			compatible = "ti,omap-ocp2scp";
> > @@ -1137,7 +1129,7 @@
> >  				      <0x4A096400 0x64>, /* phy_tx */
> >  				      <0x4A096800 0x40>; /* pll_ctrl */
> >  				reg-names = "phy_rx", "phy_tx", "pll_ctrl";
> > -				ctrl-module = <&omap_control_sata>;
> > +				syscon-phy-power = <&dra7_ctrl_core 0x374>;

why can't we use scm_conf instead of dra7_ctrl_core?
dra7_ctrl_core seems to be redundant and wrongly placed.

> >  				clocks = <&sys_clkin1>, <&sata_ref_clk>;
> >  				clock-names = "sysclk", "refclk";
> >  				syscon-pllreset = <&dra7_ctrl_core 0x3fc>;
> > -- 
> > 1.7.9.5
> > 

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/