lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Jun 2015 14:40:11 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Daniel Mack <daniel@...que.org>, David Herrmann <dh.herrmann@...glemail.com>, Djalal Harouni <tixxdz@...ndz.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> CC: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: [PATCH] kdbus: Delete an unnecessary check before the function call "kdbus_domain_unref" From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Wed, 24 Jun 2015 14:30:17 +0200 The kdbus_domain_unref() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- ipc/kdbus/fs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ipc/kdbus/fs.c b/ipc/kdbus/fs.c index d01f33b..205a3ad 100644 --- a/ipc/kdbus/fs.c +++ b/ipc/kdbus/fs.c @@ -325,9 +325,7 @@ static void fs_super_kill(struct super_block *sb) } kill_anon_super(sb); - - if (domain) - kdbus_domain_unref(domain); + kdbus_domain_unref(domain); } static int fs_super_set(struct super_block *sb, void *data) -- 2.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists