linux-kernel - Re: [PATCH] kdbus: Delete an unnecessary check before the function call "kdbus_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150624124533.GA9939@dztty>
Date:	Wed, 24 Jun 2015 13:45:33 +0100
From:	Djalal Harouni <tixxdz@...ndz.org>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] kdbus: Delete an unnecessary check before the function
 call "kdbus_domain_unref"

On Wed, Jun 24, 2015 at 02:40:11PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 24 Jun 2015 14:30:17 +0200
> 
> The kdbus_domain_unref() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  ipc/kdbus/fs.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/ipc/kdbus/fs.c b/ipc/kdbus/fs.c
> index d01f33b..205a3ad 100644
> --- a/ipc/kdbus/fs.c
> +++ b/ipc/kdbus/fs.c
> @@ -325,9 +325,7 @@ static void fs_super_kill(struct super_block *sb)
>  	}
>  
>  	kill_anon_super(sb);
> -
> -	if (domain)
> -		kdbus_domain_unref(domain);
> +	kdbus_domain_unref(domain);
>  }
>  
>  static int fs_super_set(struct super_block *sb, void *data)
> -- 
> 2.4.4
> 

Reviewed-by: Djalal Harouni <tixxdz@...ndz.org>


-- 
Djalal Harouni
http://opendz.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/