linux-kernel - RE: [PATCH] ACPICA: Delete an unnecessary check before the function call "acpi_ds_delete_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D306826@ORSMSX112.amr.corp.intel.com>
Date:	Wed, 24 Jun 2015 15:16:25 +0000
From:	"Moore, Robert" <robert.moore@...el.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	Len Brown <lenb@...nel.org>, "Zheng, Lv" <lv.zheng@...el.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"devel@...ica.org" <devel@...ica.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Julia Lawall <julia.lawall@...6.fr>
Subject: RE: [PATCH] ACPICA: Delete an unnecessary check before the function
 call "acpi_ds_delete_walk_state"

Got it, thanks.


> -----Original Message-----
> From: SF Markus Elfring [mailto:elfring@...rs.sourceforge.net]
> Sent: Wednesday, June 24, 2015 4:46 AM
> To: Len Brown; Zheng, Lv; Wysocki, Rafael J; Moore, Robert; linux-
> acpi@...r.kernel.org; devel@...ica.org
> Cc: LKML; kernel-janitors@...r.kernel.org; Julia Lawall
> Subject: [PATCH] ACPICA: Delete an unnecessary check before the function
> call "acpi_ds_delete_walk_state"
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 24 Jun 2015 13:33:47 +0200
> 
> The acpi_ds_delete_walk_state() function tests whether its argument is
> NULL and then returns immediately. Thus the test around the call is not
> needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/acpi/acpica/dsmethod.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/acpi/acpica/dsmethod.c
> b/drivers/acpi/acpica/dsmethod.c index 85bb951..188b254 100644
> --- a/drivers/acpi/acpica/dsmethod.c
> +++ b/drivers/acpi/acpica/dsmethod.c
> @@ -574,10 +574,7 @@ cleanup:
>  	/* On error, we must terminate the method properly */
> 
>  	acpi_ds_terminate_control_method(obj_desc, next_walk_state);
> -	if (next_walk_state) {
> -		acpi_ds_delete_walk_state(next_walk_state);
> -	}
> -
> +	acpi_ds_delete_walk_state(next_walk_state);
>  	return_ACPI_STATUS(status);
>  }
> 
> --
> 2.4.4