linux-kernel - Re: [PATCH v3 09/15] x86/entry/64: Migrate 64-bit and compat syscalls to new exit hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrVbfqT8Fi17+G8WdMaP0a2QcHZwOdFCeH6VZCSrsL0MGw@mail.gmail.com>
Date:	Wed, 24 Jun 2015 14:18:13 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Andy Lutomirski <luto@...nel.org>
Cc:	X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Rik van Riel <riel@...hat.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Borislav Petkov <bp@...en8.de>,
	Kees Cook <keescook@...omium.org>,
	Brian Gerst <brgerst@...il.com>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH v3 09/15] x86/entry/64: Migrate 64-bit and compat syscalls
 to new exit hooks

On Tue, Jun 23, 2015 at 7:46 PM, Andy Lutomirski <luto@...nel.org> wrote:
>
> @@ -227,11 +227,10 @@ sysexit_from_sys_call:
>         testl   %edi, ASM_THREAD_INFO(TI_flags, %rsp, SIZEOF_PTREGS)
>         jz      \exit
>         xorl    %eax, %eax              /* Do not leak kernel information */
> -       movq    %rax, R11(%rsp)
> +       jmp     int_ret_from_sys_call_irqs_off
>         movq    %rax, R10(%rsp)
>         movq    %rax, R9(%rsp)
>         movq    %rax, R8(%rsp)
> -       jmp     int_with_check
>         .endm
>

Crud.  I hate code like this with no usable test (although the thing
Denys is working on should catch this).  There's an obvious rebase
error here. :(

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/