linux-kernel - Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87oak6rm5k.wl%kuninori.morimoto.gx@renesas.com>
Date:	Wed, 24 Jun 2015 00:24:17 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	nick <xerofoify@...il.com>
CC:	Joe Perches <joe@...ches.com>, <ulf.hansson@...aro.org>,
	<ben.dooks@...ethink.co.uk>, <ykaneko0929@...il.com>,
	<laurent.pinchart+renesas@...asonboard.com>,
	<kouichi.tomita.yn@...esas.com>, <linux-mmc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma_one


Hi Joe, Nick

> >>> This adds a cast to the variables,slave_id_rx and slave_id_rx
> >>> to uintptr_t before casting to void* in order to avoid build
> >>> warning on 64bit platforms for the function, sh_mmcif_request_dma_one.
> > []
> >>> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> > []
> >>> @@ -398,8 +398,8 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host,
> >>>  
> >>>  	if (pdata)
> >>>  		slave_data = direction == DMA_MEM_TO_DEV ?
> >>> -			(void *)pdata->slave_id_tx :
> >>> -			(void *)pdata->slave_id_rx;
> >>> +			(void *)(uintptr_t)pdata->slave_id_tx :
> >>> +			(void *)(uintptr_t)pdata->slave_id_rx;
> > 
> > It's far more common (~10:1) in the kernel to cast using
> > 	(<type> *)(unsigned long)<foo>
> > than
> > 	(<type> *)(uintptr_t)<foo>
> > 
> Joe,
> I agree it's more common in the kernel but one of the maintainers when I sent
> this patch a month ago requested I use uintpr_t instead of unsigned long for
> the casting. Otherwise I would have done the cast to fix the build warning
> with unsigned long instead.

This mail
http://thread.gmane.org/gmane.linux.kernel.mmc/32304


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/