linux-kernel - Re: [GIT PULL] f2fs updates for v4.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150625062946.GU17109@ZenIV.linux.org.uk>
Date:	Thu, 25 Jun 2015 07:29:46 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Jaegeuk Kim <jaegeuk@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux FS Dev Mailing List <linux-fsdevel@...r.kernel.org>,
	Linux F2FS Dev Mailing List 
	<linux-f2fs-devel@...ts.sourceforge.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [GIT PULL] f2fs updates for v4.2

On Thu, Jun 25, 2015 at 05:33:34AM +0100, Al Viro wrote:

> Said that, f2fs_symlink() looks odd - we create a directory entry *before*
> doing page_symlink().  And if it (or encryption) fails, I don't see anything
> that would remove that new directory entry.  What are we ending up with
> in such case?

PS: other page_symlink() users tend to do it first and if it fails we just
decrement link count and iput() the sucker.

	BTW, while grepping for that stuff...  Why do we have
->delete_inode() set to generic_delete_inode() on ramfs?  After all,
we never hash the inodes in there, so default will do nicely, and
it's kinder of branch prediction - we have
        if (op->drop_inode)
                drop = op->drop_inode(inode);
        else
                drop = generic_drop_inode(inode);
and generic_drop_inode() is inlined there...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/