linux-kernel - Re: [GIT PULL] f2fs updates for v4.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150625064522.GA44674@jaegeuk-mac02.mot-mobility.com>
Date:	Wed, 24 Jun 2015 23:48:26 -0700
From:	Jaegeuk Kim <jaegeuk@...nel.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux FS Dev Mailing List <linux-fsdevel@...r.kernel.org>,
	Linux F2FS Dev Mailing List 
	<linux-f2fs-devel@...ts.sourceforge.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [GIT PULL] f2fs updates for v4.2

On Thu, Jun 25, 2015 at 07:32:36AM +0100, Al Viro wrote:
> On Wed, Jun 24, 2015 at 10:50:10PM -0700, Jaegeuk Kim wrote:
> 
> > Right, I missed merging the fix-up patch in linux-next into my pull-request.
> > At a glance, I think there is no problem; except 80 column width, though.
> > 
> > Also, agreed that I need to take a look at deleting the dentry to deal with that
> > failure case.
> 
> 	Why not set the symlink up first and create a directory entry only
> if that succeeds?  Looks like it's less work that way...

Cause f2fs_add_link initializes some on-disk inode structures to be used when
writing data.

Maybe simply call f2fs_unlink?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/