[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1435217491.16792.5.camel@tiscali.nl>
Date: Thu, 25 Jun 2015 09:31:31 +0200
From: Paul Bolle <pebolle@...cali.nl>
To: Michal Simek <michal.simek@...inx.com>,
Moritz Fischer <moritz.fischer@...us.com>,
jassisinghbrar@...il.com
Cc: linux-kernel@...r.kernel.org, robh+dt@...nel.org,
pawel.moll@....com, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
soren.brinkmann@...inx.com, akpm@...ux-foundation.org,
gregkh@...uxfoundation.org, mchehab@....samsung.com, arnd@...db.de,
joe@...ches.com, jingoohan1@...il.com, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP
mailbox.
On Thu, 2015-06-25 at 08:55 +0200, Michal Simek wrote:
> On 06/24/2015 10:36 PM, Paul Bolle wrote:
> > On Tue, 2015-06-23 at 11:00 -0700, Moritz Fischer wrote:
> > > +MODULE_ALIAS("platform:xilinx-mailbox");
> >
> > So I think this MODULE_ALIAS() is only useful if, in short, there's
> > a corresponding platform_device created. Ie, a platform_device with
> > a name "xilinx-mailbox" that will fire of a "MODALIAS=platform:xili
> > nx-mailbox" when it's created.
> >
> > I couldn't spot such a platform_device. Provided git grep didn't
> > let me down here: what breaks if this line is dropped?
>
> IRC you don't need to have this platform_device in the kernel
> present. Only one thing which should be check is that this driver can
> be used as platform device driver.
>
> The only one problematic part is devm_clk_get() and this should be
> checked if you can use this as platform driver. From the first look
> it looks like that this will break it.
>
> Anyway if Moritz is able to use this a platform driver he can keep
> this line there. If not, it should be removed.
But, assuming this works as a platform driver, where does the "xilinx
-mailbox" platform device originate?
Paul Bolle
PS Evolution 3.16 is nearly unbearable in its handling of replies to
plain text messages. Doe anyone know how to make it handle them
sensibly?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists