lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <558BC9D0.1080500@mev.co.uk>
Date:	Thu, 25 Jun 2015 10:28:48 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Santosh <santhosh.pai88@...oo.com>
CC:	hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return
 error code

On 25/06/15 05:40, Sudip Mukherjee wrote:
> On Wed, Jun 24, 2015 at 11:22:24PM +0530, Santosh wrote:
>>    try_module_get fails when the reference count of the module is not
>>    allowed to be incremented ,and hence -ENXIO is returned indicating
>>    no device or address.
> 1) this patch is 2/2, but then where is your 1/2 patch?
> 2) You have used "santosh" in your email From: header.
>     use "santosh	pai" there. It should be same as what you use in your
>     Signed-off-by:

3) Most of the commit message body (apart from the Signed-off-by line) 
has been indented by 2 spaces for no good reason.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ