[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1435224937.16792.19.camel@tiscali.nl>
Date: Thu, 25 Jun 2015 11:35:37 +0200
From: Paul Bolle <pebolle@...cali.nl>
To: Michal Simek <michal.simek@...inx.com>,
Moritz Fischer <moritz.fischer@...us.com>,
jassisinghbrar@...il.com
Cc: linux-kernel@...r.kernel.org, robh+dt@...nel.org,
pawel.moll@....com, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
soren.brinkmann@...inx.com, akpm@...ux-foundation.org,
gregkh@...uxfoundation.org, mchehab@....samsung.com, arnd@...db.de,
joe@...ches.com, jingoohan1@...il.com, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv5 2/2] mailbox: Adding driver for Xilinx LogiCORE IP
mailbox.
On Thu, 2015-06-25 at 09:47 +0200, Michal Simek wrote:
> It has to be platform_device somewhere for sure.
> In past we had folder in arch/microblaze/platform folder.
> Currently you can add this code to for example
> arch/microblaze/kernel/platform.c
>
> But as I said I don't think it is really important. There will be a
> lot
> of others drivers in the kernel which can be used as platform drivers
> but you are not able to find out platform_device for it.
Because, like probably happens with this driver, the OF infrastructure
makes sure the .probe and .remove functions will eventually called?
> The important part is that driver can work as is.
Sure.
But I was talking about the MODULE_ALIAS() macro. Trivial as it is,
since I still don't see where a "MODALIAS=platform:xilinx-mailbox"
uevent could come from I still don't see the point of this line. As I
asked in my first message: what breaks if this line is dropped?
> Also it is quite common that users create own BSP for their custom
> boards but they don't push it to mainline.
I can't recall what BSP means. Anyhow, why should we care about boards
not pushed into mainline?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists