linux-kernel - Re: [PATCH 12/13] perf thread_map: Change map entries into a struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150625134505.GA3253@kernel.org>
Date:	Thu, 25 Jun 2015 10:45:05 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	David Ahern <dsahern@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 12/13] perf thread_map: Change map entries into a struct

Em Thu, Jun 25, 2015 at 10:38:41AM +0200, Jiri Olsa escreveu:
> On Tue, Jun 23, 2015 at 06:47:26PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Jiri Olsa <jolsa@...nel.org>
> > 
> > We need to store command names with the pid. Changing map entries to be
> > a struct holding pid. Process name is coming in shortly.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > Cc: Andi Kleen <ak@...ux.intel.com>
> > Cc: David Ahern <dsahern@...il.com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Cc: Stephane Eranian <eranian@...gle.com>
> > Link: http://lkml.kernel.org/r/1435012588-9007-2-git-send-email-jolsa@kernel.org
> > [ Split providing the set/get accessors from transforming the entries structs ]
> 
> the comment in [] is wrong..
> 
> and you missed following hunk:
> 
> ---
>  static struct thread_map *thread_map__realloc(struct thread_map *map, int nr)
>  {
> -       size_t size = sizeof(*map) + sizeof(pid_t) * nr;
> +       size_t size = sizeof(*map) + sizeof(struct thread_map_data) * nr;
> ---
> 
> shouldn't be fatal, it probably has the same or biggger size ATM
> I'll include the fix in the next version

Yeah, sorry about that, should have noticed that, but as you said, code
wise it is harmless.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/