linux-kernel - Re: [PATCH v2] staging/comedi: remove unnecessary check around pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <558C1299.3060405@mev.co.uk>
Date:	Thu, 25 Jun 2015 15:39:21 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Maninder Singh <maninder1.s@...sung.com>,
	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
CC:	pankaj.m@...sung.com
Subject: Re: [PATCH v2] staging/comedi: remove unnecessary check around pci_dev_put

On 25/06/15 12:14, Maninder Singh wrote:
> pci_dev_put checks for NULL pointer itself,
> reported by coccinelle
>
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Reviewed-by: Yogesh Gaur <yn.gaur@...sung.com>
> ---
> v2: changelog typo cehcks -> checks
>
>   drivers/staging/comedi/drivers/adl_pci9118.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
> index fb3043d..19b5806 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -1717,8 +1717,7 @@ static void pci9118_detach(struct comedi_device *dev)
>   		pci9118_reset(dev);
>   	comedi_pci_detach(dev);
>   	pci9118_free_dma(dev);
> -	if (pcidev)
> -		pci_dev_put(pcidev);
> +	pci_dev_put(pcidev);
>   }
>
>   static struct comedi_driver adl_pci9118_driver = {
>

The patch does no harm, but as mentioned by Dan Carpenter, if pcidev 
could be NULL (which it could be), we should keep the test for readability.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/