linux-kernel - RE: [PATCH v4 4/9] staging:lustre: merge socklnd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Jun 2015 15:02:34 +0000
From:	"Simmons, James A." <simmonsja@...l.gov>
To:	'Geert Uytterhoeven' <geert@...ux-m68k.org>,
	Guenter Roeck <linux@...ck-us.net>
CC:	driverdevel <devel@...verdev.osuosl.org>,
	James Simmons <jsimmons@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	"lustre-devel@...ts.lustre" <lustre-devel@...ts.lustre>
Subject: RE: [PATCH v4 4/9] staging:lustre: merge socklnd_lib-linux.h into
 socklnd.h

>On Thu, Jun 25, 2015 at 3:33 AM, Guenter Roeck <linux@...ck-us.net> wrote:
>> I have not tested it, but I think the following may fix the problem
>> while avoiding any include problems. Since pt_regs is used in the file,
>> one could argue that it should be declared.
>
>Indeed. I tried that, but...
>
>> --
>> diff --git a/arch/m68k/include/asm/irq.h b/arch/m68k/include/asm/irq.h
>> index 81ca118d58af..28ffa8d59cf0 100644
>> --- a/arch/m68k/include/asm/irq.h
>> +++ b/arch/m68k/include/asm/irq.h
>> @@ -74,6 +74,8 @@ extern unsigned int irq_canonicalize(unsigned int irq);
>>  #define irq_canonicalize(irq)  (irq)
>>  #endif /* !(CONFIG_M68020 || CONFIG_M68030 || CONFIG_M68040 || CONFIG_M68060) */
>>
>> +struct pt_regs;
>> +
>>  asmlinkage void do_IRQ(int irq, struct pt_regs *regs);
>>  extern atomic_t irq_err_count;
>
>... asmlinkage and atomic_t are also needed.
>
>I didn't want to risk introducing more breakage by adding (at least) three
>more includes.

Hi Geert

      Long time. I agree the above is not the best approach. Lets fix lustre instead.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/