linux-kernel - Re: [PATCH] keys: Use non-conflicting variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150625153632.GB11592@gondor.apana.org.au>
Date:	Thu, 25 Jun 2015 23:36:32 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>
Subject: Re: [PATCH] keys: Use non-conflicting variable name

On Wed, Jun 24, 2015 at 03:27:01PM -0700, Guenter Roeck wrote:
> arm64:allmodconfig fails to build as follows.
> 
> In file included from include/acpi/platform/aclinux.h:74:0,
>                  from include/acpi/platform/acenv.h:173,
>                  from include/acpi/acpi.h:56,
>                  from include/linux/acpi.h:37,
>                  from ./arch/arm64/include/asm/dma-mapping.h:21,
>                  from include/linux/dma-mapping.h:86,
>                  from include/linux/skbuff.h:34,
>                  from include/crypto/algapi.h:18,
>                  from crypto/asymmetric_keys/rsa.c:16:
> include/linux/ctype.h:15:12: error: expected ‘;’, ‘,’ or ‘)’
> 		before numeric constant
>  #define _X 0x40 /* hex digit */
>             ^
> crypto/asymmetric_keys/rsa.c:123:47: note: in expansion of macro ‘_X’
>  static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
>                                                ^
> crypto/asymmetric_keys/rsa.c: In function ‘RSA_verify_signature’:
> crypto/asymmetric_keys/rsa.c:256:2: error:
> 		implicit declaration of function ‘RSA_I2OSP’
> 
> The problem is caused by an unrelated include file change, resulting in
> the inclusion of ctype.h on arm64. This in turn causes the local variable
> _X to conflict with macro _X used in ctype.h.
> 
> Fixes: b6197b93fa4b ("arm64 : Introduce support for ACPI _CCA object")
> Cc: Suthikulpanit, Suravee <Suravee.Suthikulpanit@....com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/