linux-kernel - Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Jun 2015 08:49:30 -0700
From:	Juston Li <juston.h.li@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	teddy.wang@...iconmotion.com, Greg KH <gregkh@...uxfoundation.org>,
	linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement

On Thu, Jun 25, 2015 at 5:17 AM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
>> Fix brace placement errors caught by checkpatch.pl
>> ERROR: that open brace { should be on the previous line
>>
>> Signed-off-by: Juston Li <juston.h.li@...il.com>
>> ---
> <snip>
>> @@ -71,14 +66,11 @@ static void setDisplayControl(int ctrl, int dispState)
>>                       POKE32(PANEL_DISPLAY_CTRL, ulDisplayCtrlReg);
>>               }
>>
>> -     }
>>       /* Set the secondary display control */
>> -     else
>> -     {
>> +     } else {
> just a thought. The comment previously was at the beginning of the else
> block, but now it will be placed inside the if block - at the end.
> will it confuse code readers afterwards?
>
> regards
> sudip

I placed it above the else to make it consistent with the if statement with
similar comment that the else corresponds to:

/* Set the primary display control */
- if (!ctrl)+ if (!ctrl) {

Thanks
Juston
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/