linux-kernel - Re: [PATCH 1/2] perf header: Delete an unnecessary check before the function call "free_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150625164523.GG3253@kernel.org>
Date:	Thu, 25 Jun 2015 13:45:23 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 1/2] perf header: Delete an unnecessary check before the
 function call "free_event_desc"

Em Thu, Jun 25, 2015 at 06:22:18PM +0200, SF Markus Elfring escreveu:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 25 Jun 2015 17:12:32 +0200
> 
> The free_event_desc() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.

Thanks, applying.

- Arnaldo
 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  tools/perf/util/header.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 21a77e7..03ace57 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -1063,8 +1063,7 @@ out:
>  	free(buf);
>  	return events;
>  error:
> -	if (events)
> -		free_event_desc(events);
> +	free_event_desc(events);
>  	events = NULL;
>  	goto out;
>  }
> -- 
> 2.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/