linux-kernel - Re: [PATCH] sched: split sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWOOpqt9A_imP6dnXmMtkJqbTgvu6sRJ3iewF=yRb0R6A@mail.gmail.com>
Date:	Thu, 25 Jun 2015 10:04:37 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [PATCH] sched: split sched_switch trace event into two

On Wed, Jun 24, 2015 at 6:05 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index c86935a..681fc50 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -2219,6 +2219,7 @@ prepare_task_switch(struct rq *rq, struct task_struct *prev,
>>                   struct task_struct *next)
>>  {
>>       trace_sched_switch(prev, next);
>> +     trace_sched_out(prev);
>
> Tracepoints are low overhead, but they do take up space. This is a
> useless tracepoint. If anything, I'll work on adding an alias or
> something. But please don't add a tracepoint next to a tracepoint that
> encompasses the data.


Good point, agreed.

The reason why I picked sched_in and sched_out is that their names are
much better than sched_switch and sched_switch_post as you proposed.

Before you add tracepoint alias, adding sched_switch_post is better,
we probably can just add sched_in and sched_out as aliases to them after
your work is done. ;)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/