linux-kernel - Re: [RFC][PATCH] printk: Fixup the nmi printk mess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150625181459.GB3644@twins.programming.kicks-ass.net>
Date:	Thu, 25 Jun 2015 20:14:59 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Petr Mladek <pmladek@...e.cz>
Cc:	Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
	jkosina@...e.cz, paulmck@...ux.vnet.ibm.com,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC][PATCH] printk: Fixup the nmi printk mess

On Fri, Jun 12, 2015 at 05:35:05PM +0200, Petr Mladek wrote:
> I have got another idea. We already use a lock to synchronize
> readers. It might be used to avoid the race and keep the global
> flush().
> 
> I played with it, see below. It is based on 2nd Peter's patch
> where I modified only struct nmi_seq_buf,  __printk_nmi_flush(),
> and vprintk_nmi().
> 
> It forces the reader to flush everything or nothing. It is less
> effective than the previous code but much more simple.
> 
> It seems to work but it is just a proof-of-concept. Also I think that
> it would be possible to use the normal seq_buf in the end.

Sorry, got side tracked. Yes this looks ok. Want to submit a proper
patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/