lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jun 2015 20:54:45 +0200 From: Daniel Kiper <daniel.kiper@...cle.com> To: David Vrabel <david.vrabel@...rix.com> Cc: xen-devel@...ts.xenproject.org, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats On Thu, Jun 25, 2015 at 08:38:36PM +0200, Daniel Kiper wrote: > On Thu, Jun 25, 2015 at 06:11:00PM +0100, David Vrabel wrote: > > The stats used for memory hotplug make no sense and are fiddled with > > in odd ways. Remove them and introduce total_pages to track the total > > number of pages (both populated and unpopulated) including those within > > hotplugged regions (note that this includes not yet onlined pages). > > > > This will be useful when deciding whether additional memory needs to be > > hotplugged. > > > > Signed-off-by: David Vrabel <david.vrabel@...rix.com> > > Nice optimization! I suppose that it is remnant from very early > version of memory hotplug. Probably after a few patch series > iterations hotplug_pages and balloon_hotplug lost their meaning > and I did not catch it. Additionally, as I can see there is not > any consumer for total_pages here. So, I think that we can go > further and remove this obfuscated code at all. Err... Ignore that. I missed next patch... Should not both of them merged in one or commit comment contain clear info that this will be used by next patch. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists