linux-kernel - Re: [PATCH] extcon: arizona: Declare 3-pole jack if we detect open circuit on mic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Jun 2015 10:07:55 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	myungjoo.ham@...sung.com, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] extcon: arizona: Declare 3-pole jack if we detect open
 circuit on mic

On 06/26/2015 12:47 AM, Charles Keepax wrote:
> Detecting an open-circuit on the microphone pin, usually means the
> headset has a microphone but the cable is faulty. Currently the code
> will simply stop detecting and declare nothing in this situation. It is
> better to declare this as headphones such that the user can still use
> their headset as plain headphones even if the microphone is faulty.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 4c47eb2..e216a97 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -829,7 +829,10 @@ static void arizona_micd_detect(struct work_struct *work)
>  	/* Due to jack detect this should never happen */
>  	if (!(val & ARIZONA_MICD_STS)) {
>  		dev_warn(arizona->dev, "Detected open circuit\n");
> +		info->mic = false;
> +		arizona_stop_mic(info);
>  		info->detecting = false;
> +		arizona_identify_headphone(info);
>  		goto handled;
>  	}
>  
> 

Applied it.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/