linux-kernel - Re: [RFC PATCH] arm64: bpf: fix endianness conversion bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <558D0C97.2070107@plumgrid.com>
Date:	Fri, 26 Jun 2015 01:25:59 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Xi Wang <xi.wang@...il.com>, linux-arm-kernel@...ts.infradead.org
CC:	linux-kernel@...r.kernel.org, Zi Shen Lim <zlim.lnx@...il.com>
Subject: Re: [RFC PATCH] arm64: bpf: fix endianness conversion bugs

On 6/25/15 6:39 PM, Xi Wang wrote:
> Upper bits should be zeroed in endianness conversion:
>
> - even when there's no need to change endianness (i.e., BPF_FROM_BE
>    on big endian or BPF_FROM_LE on little endian);
>
> - after rev16.
>
> This patch fixes such bugs by emitting extra instructions to clear
> upper bits.
>
> Cc: Zi Shen Lim<zlim.lnx@...il.com>
> Cc: Alexei Starovoitov<ast@...mgrid.com>
> Fixes: e54bcde3d69d ("arm64: eBPF JIT compiler")
> Signed-off-by: Xi Wang<xi.wang@...il.com>

Acked-by: Alexei Starovoitov <ast@...mgrid.com>

> The current testsuite catches the 16-bit bugs.  I'll send a separate
> patch that extends test_bpf to catch the 32-bit ones.

looking forward to it. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/