linux-kernel - [tip:perf/urgent] perf header: Delete an unnecessary check before the calling free_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Jun 2015 01:44:06 -0700
From:	tip-bot for Markus Elfring <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	acme@...hat.com, linux-kernel@...r.kernel.org, hpa@...or.com,
	a.p.zijlstra@...llo.nl, elfring@...rs.sourceforge.net,
	mingo@...nel.org, tglx@...utronix.de, julia.lawall@...6.fr
Subject: [tip:perf/urgent] perf header:
  Delete an unnecessary check before the calling free_event_desc()

Commit-ID:  4cc97614812e96c135e369f3d723fcda07d33437
Gitweb:     http://git.kernel.org/tip/4cc97614812e96c135e369f3d723fcda07d33437
Author:     Markus Elfring <elfring@...rs.sourceforge.net>
AuthorDate: Thu, 25 Jun 2015 17:12:32 +0200
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Thu, 25 Jun 2015 15:15:49 -0300

perf header: Delete an unnecessary check before the calling free_event_desc()

The free_event_desc() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
Cc: Julia Lawall <julia.lawall@...6.fr>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: kernel-janitors@...r.kernel.org
Link: http://lkml.kernel.org/r/558C2ABA.3000603@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/util/header.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 21a77e7..03ace57 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1063,8 +1063,7 @@ out:
 	free(buf);
 	return events;
 error:
-	if (events)
-		free_event_desc(events);
+	free_event_desc(events);
 	events = NULL;
 	goto out;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/