linux-kernel - Re: arm64 allmodconfig failure in expansion of macro ‘

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150626100944.GA19292@gondor.apana.org.au>
Date:	Fri, 26 Jun 2015 19:09:44 +0900
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Will Deacon <will.deacon@....com>
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: arm64 allmodconfig failure in expansion of macro ‘_X’

On Fri, Jun 26, 2015 at 11:08:05AM +0100, Will Deacon wrote:
> Hi all,
> 
> arm64 allmodconfig fails to build with mainline due to the following:
> 
> 
>   In file included from include/acpi/platform/aclinux.h:74:0,
>                    from include/acpi/platform/acenv.h:173,
>                    from include/acpi/acpi.h:56,
>                    from include/linux/acpi.h:37,
>                    from ./arch/arm64/include/asm/dma-mapping.h:21,
>                    from include/linux/dma-mapping.h:86,
>                    from include/linux/skbuff.h:34,
>                    from include/crypto/algapi.h:18,
>                    from crypto/asymmetric_keys/rsa.c:16:
>   include/linux/ctype.h:15:12: error: expected ‘;’, ‘,’ or ‘)’ before numeric constant
>    #define _X 0x40 /* hex digit */
>               ^
>   crypto/asymmetric_keys/rsa.c:123:47: note: in expansion of macro ‘_X’
>    static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
>                                                  ^
>   crypto/asymmetric_keys/rsa.c: In function ‘RSA_verify_signature’:
>   crypto/asymmetric_keys/rsa.c:256:2: error: implicit declaration of function ‘RSA_I2OSP’ [-Werror=implicit-function-declaration]
>     ret = RSA_I2OSP(m, k, &EM);
> 
> 
> This is thanks to the following function type:
> 
>   static int RSA_I2OSP(MPI x, size_t xLen, u8 **__X)
> 
> conflicting with the _X #define in linux/ctype.h:
> 
>   #define _X      0x40    /* hex digit */
> 
> Simple patch below, but solving this problem with more underscores feels
> slightly inhumane.

Thanks but I've already merged a similar patch yesterday.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/