linux-kernel - Re: [PATCH] staging: gdm72xx: Split Kconfig descriptions into more lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150626112938.GA19389@goodgumbo.baconseed.org>
Date:	Fri, 26 Jun 2015 13:29:41 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Daniel Grimshaw <grimshaw@...ux.vnet.ibm.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	gregkh@...uxfoundation.org, benchan@...omium.org,
	rafael.j.wysocki@...el.com, tj@...nel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH] staging: gdm72xx: Split Kconfig descriptions into more
 lines

On Thu, Jun 25, 2015 at 03:36:46PM -0700, Daniel Grimshaw wrote:
> I am a high school student trying to become familiar with linux kernel
> development. This is my first patch.
> 
> checkpatch.pl throws a warning that config WIMAX_GDM72XX_QOS, config
> WIMAX_GDM72XX_K_MODE, and config WIMAX_GDM72XX_USB do not have enough
> of a description. By splitting the current description into multiple
> lines, the warning is removed.
> 
> The module still worked with these changes when tested.
> 
> Signed-off-by: Daniel Grimshaw <grimshaw@...ux.vnet.ibm.com>
> 

Hello Daniel,

Nice to see people submitting their first patch. Welcome :)

Besides what Dan Carpenter said, I wanted to add a comment about how to send
patches. Normally maintainers don't accept patches as attachments. You want to
send the patch inline.

I recommend these two resources to learn how:
http://kernelnewbies.org/FirstKernelPatch
Greg's talk "Write and Submit your first Linux kernel Patch"
  - https://www.youtube.com/watch?v=LLBrBBImJt4

There is a bit of a learning curve. It is normal to not get it right the first
time. Feel free to email me directly with any further questions about this.

Happy hacking,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/