linux-kernel - Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <558D51D4.9060202@cogentembedded.com>
Date:	Fri, 26 Jun 2015 16:21:24 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"David S. Miller" <davem@...emloft.net>,
	Antonio Borneo <borneo.antonio@...il.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on
 HAS_DMA

Hello.

On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote:

> If NO_DMA=y:

>      ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-rhine.ko] undefined!
>      ERROR: "dma_set_mask" [drivers/net/ethernet/via/via-rhine.ko] undefined!
>      ERROR: "dma_mapping_error" [drivers/net/ethernet/via/via-rhine.ko] undefined!
>      ERROR: "dma_map_single" [drivers/net/ethernet/via/via-rhine.ko] undefined!
>      ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined!
>      ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined!
>      ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-rhine.ko] undefined!
>      ERROR: "dma_map_page" [drivers/net/ethernet/via/via-velocity.ko] undefined!
>      ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-velocity.ko] undefined!
>      ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined!
>      ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-velocity.ko] undefined!
>      ERROR: "dma_map_single" [drivers/net/ethernet/via/via-velocity.ko] undefined!
>      ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined!

> Before, the symbols depended implicitly on HAS_DMA through PCI or
> USE_OF.  Add explicit dependencies on HAS_DMA to fix this.

> Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with OF_???")

Fixes: b7d3282a245f ("net: via/Kconfig: replace USE_OF with OF_???")

> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/