linux-kernel - Re: [-next] fib_dump_info() suspicious RCU usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150626142447.GV588@gospo.home.greyhouse.net>
Date:	Fri, 26 Jun 2015 10:24:48 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:	Dinesh Dutt <ddutt@...ulusnetworks.com>,
	Scott Feldman <sfeldma@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [-next] fib_dump_info() suspicious RCU usage

On Fri, Jun 26, 2015 at 06:35:40PM +0900, Sergey Senozhatsky wrote:
> Hello,
> 
> Since 0eeb075fad736 ('net: ipv4 sysctl option to ignore routes when nexthop
> link is down') fib_dump_info() and fib_sync_up() are using __in_dev_get_rcu(),
> which requires (missing) RCU read side protection.

Yep, I can reproduce this now.  Thanks for reporting.

I'll take a look and should be able to post an easy fix quickly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/