linux-kernel - Re: [PATCH] staging: rtl8712: rtl871x_security.c: remove unnecessary variable initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150626155025.GA463@goodgumbo.baconseed.org>
Date:	Fri, 26 Jun 2015 17:50:27 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Sunil Shahu <shshahu@...il.com>
Cc:	gregkh@...uxfoundation.org, dan.carpenter@...cle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	sudipm.mukherjee@...il.com
Subject: Re: [PATCH] staging: rtl8712: rtl871x_security.c: remove unnecessary
 variable initialization

On Fri, Jun 26, 2015 at 07:42:24PM +0530, Sunil Shahu wrote:
> Variable "u32 c" always re-initialize in for loop.
> Initialized value of "u32 c" is not used in function
> and is redundant, hence removed.
> 
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Sunil Shahu <shshahu@...il.com>
> ---
>  drivers/staging/rtl8712/rtl871x_security.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
> index 21465c9..8627928 100644
> --- a/drivers/staging/rtl8712/rtl871x_security.c
> +++ b/drivers/staging/rtl8712/rtl871x_security.c
> @@ -125,7 +125,7 @@ static u8 crc32_reverseBit(u8 data)
>  static void crc32_init(void)
>  {
>  	sint i, j;
> -	u32 c = 0x12340000;
> +	u32 c;
>  	u8 *p = (u8 *)&c, *p1;
>  	u8 k;
>  
> -- 
> 1.9.1

The patch is good, the value assigned to c is immediately overwritten.

Unfortunately the patch fails to apply in staging-testing and linux-next. Could
you please rebase?

Thanks,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/