linux-kernel - Re: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree

Open Source and information security mailing list archives

Message-ID: <CADnq5_Of_+3qvZKnBUqexGHfNJxWGmEFJ+MXxhhpv-veLXYCbA@mail.gmail.com>
Date:	Fri, 26 Jun 2015 13:01:24 -0400
From:	Alex Deucher <alexdeucher@...il.com>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	Dave Airlie <airlied@...ux.ie>,
	"Deucher, Alexander" <alexander.deucher@....com>,
	Christian Koenig <christian.koenig@....com>,
	"Zhou, Jammy" <Jammy.Zhou@....com>, yanyang1 <young.yang@....com>,
	"Li, Samuel" <samuel.li@....com>,
	Marek Olšák <marek.olsak@....com>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>, pankaj.m@...sung.com
Subject: Re: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree

On Fri, Jun 26, 2015 at 3:56 AM, Maninder Singh <maninder1.s@...sung.com> wrote:
> kfree(NULL) is safe and this check is probably not required
>
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Reviewed-by: Vaneet Narang <v.narang@...sung.com>
> Reviewed-by: Christian Konig <christian.koenig@....com>

Applied.  thanks!

Alex

> ---
> v2: Chnged shortlog prefix - gpu/amdgpu
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..a85cd08 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
>         amdgpu_fence_driver_fini(adev);
>         amdgpu_fbdev_fini(adev);
>         r = amdgpu_fini(adev);
> -       if (adev->ip_block_enabled)
> -               kfree(adev->ip_block_enabled);
> +       kfree(adev->ip_block_enabled);
>         adev->ip_block_enabled = NULL;
>         adev->accel_working = false;
>         /* free i2c buses */
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives