lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jun 2015 20:16:31 -0700 From: Tien Hock Loh <thloh@...era.com> To: Masahiro Yamada <yamada.masahiro@...ionext.com> CC: <thloh.linux@...il.com>, <linux-gpio@...r.kernel.org>, Linus Walleij <linus.walleij@...aro.org>, Alexandre Courbot <gnurou@...il.com>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] gpio: altera: fix return value of altera_gpio_remove() Acked-by: Tien Hock Loh <thloh@...era.com> On Wed, 2015-06-17 at 20:59 +0900, Masahiro Yamada wrote: > The remove callback never succeeds, which seems odd. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> > --- > > I wonder why nobody has pointed this out before me. > I am suspecting -EIO might be intentional. > I hope some Altera guys will give me comments. > > > drivers/gpio/gpio-altera.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c > index c653c83..5861550 100644 > --- a/drivers/gpio/gpio-altera.c > +++ b/drivers/gpio/gpio-altera.c > @@ -339,7 +339,7 @@ static int altera_gpio_remove(struct platform_device *pdev) > > of_mm_gpiochip_remove(&altera_gc->mmchip); > > - return -EIO; > + return 0; > } > > static const struct of_device_id altera_gpio_of_match[] = { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists