linux-kernel - Re: [PATCH] xhci:Change function name from xhci_configure_endpoint_result to xhci_trace_endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150626184805.GA1612@kroah.com>
Date:	Fri, 26 Jun 2015 11:48:05 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	mathias.nyman@...el.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci:Change function name from
 xhci_configure_endpoint_result to xhci_trace_endpoint_result

On Fri, Jun 26, 2015 at 02:25:48PM -0400, Nicholas Krause wrote:
> This changes the name of the function xhci_configure_endpoint_result
> to xhci_trace_endpoint_result to more clearly state the actual
> intended use of this function which is tracing the passed command
> status, on the passed usb/xhci structure pointers of udev and xhci
> respectfully.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

Dammit, my filters broke, I need to go fix them now...

> ---
>  drivers/usb/host/xhci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 36bf089..2e086ef 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1839,7 +1839,7 @@ static void xhci_zero_in_ctx(struct xhci_hcd *xhci, struct xhci_virt_device *vir
>  	}
>  }
>  
> -static int xhci_configure_endpoint_result(struct xhci_hcd *xhci,
> +static int xhci_trace_endpoint_result(struct xhci_hcd *xhci,
>  		struct usb_device *udev, u32 *cmd_status)
>  {
>  	int ret;
> @@ -2683,7 +2683,7 @@ static int xhci_configure_endpoint(struct xhci_hcd *xhci,
>  	wait_for_completion(command->completion);
>  
>  	if (!ctx_change)
> -		ret = xhci_configure_endpoint_result(xhci, udev,
> +		ret = xhci_trace_endpoint_result(xhci, udev,
>  						     &command->status);

No, please stop, this is doing nothing but unneeded code churn, and do
absolutely nothing.

Because you are banned from vger, these patches are not being sent to
the public, so I will not accept them either.

I will not be accepting any patches from you for at least a year, maybe
two, so don't waste your time.  Please go work on some other open source
project, if you really want to contribute to the Linux ecosystem, as
long as it is not the kernel.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/