linux-kernel - Re: [PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check before the function call "free_tce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <558EC13A.30709@users.sourceforge.net>
Date:	Sat, 27 Jun 2015 17:28:58 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Muli Ben-Yehuda <muli@...ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	discuss@...-64.org
CC:	Jon Mason <jdmason@...zu.us>, LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check
 before the function call "free_tce_table"

>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>> Date: Sat, 22 Nov 2014 12:55:28 +0100
>>
>> The free_tce_table() function tests whether its argument is NULL and then
>> returns immediately. Thus the test around the call is not needed.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> 
> Looks good to me
> 
> Acked-by: Jon Mason <jdmason@...zu.us>
> 
> 
>> ---
>>  arch/x86/kernel/pci-calgary_64.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
>> index 0497f71..d22a386 100644
>> --- a/arch/x86/kernel/pci-calgary_64.c
>> +++ b/arch/x86/kernel/pci-calgary_64.c
>> @@ -1476,8 +1476,7 @@ cleanup:
>>         for (--bus; bus >= 0; --bus) {
>>                 struct calgary_bus_info *info = &bus_info[bus];
>>
>> -               if (info->tce_space)
>> -                       free_tce_table(info->tce_space);
>> +               free_tce_table(info->tce_space);
>>         }
>>         return -ENOMEM;
>>  }
>> --
>> 2.1.3
>>

Do the chances increase to integrate this update suggestion
into another source code repository?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/