linux-kernel - Re: imx: apf27: the board no longer boot with latest git kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 27 Jun 2015 14:34:17 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Philippe Reynes <tremyfr@...il.com>
Cc:	Shawn Guo <shawn.guo@...aro.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	linux-kernel <Linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: imx: apf27: the board no longer boot with latest git kernel

On Sat, Jun 27, 2015 at 2:26 PM, Philippe Reynes <tremyfr@...il.com> wrote:

> I've looked the code in drivers/clocksource/timer-imx-gpt.c, in the
> definition
> of imx_gpt_type, there is :
>         GPT_TYPE_IMX21,         /* i.MX21/27 */
>
> So I've done a little change in your patch, I've used imx21_timer_init_dt
> for
> imx27 :
>
> --- a/drivers/clocksource/timer-imx-gpt.c
> +++ b/drivers/clocksource/timer-imx-gpt.c
> @@ -529,6 +529,7 @@ static void __init imx6dl_timer_init_dt(struct
> device_node *np)
>   CLOCKSOURCE_OF_DECLARE(imx1_timer, "fsl,imx1-gpt", imx1_timer_init_dt);
>  CLOCKSOURCE_OF_DECLARE(imx21_timer, "fsl,imx21-gpt", imx21_timer_init_dt);
> +CLOCKSOURCE_OF_DECLARE(imx27_timer, "fsl,imx27-gpt", imx21_timer_init_dt);
>  CLOCKSOURCE_OF_DECLARE(imx31_timer, "fsl,imx31-gpt", imx31_timer_init_dt);
>  CLOCKSOURCE_OF_DECLARE(imx25_timer, "fsl,imx25-gpt", imx31_timer_init_dt);
>  CLOCKSOURCE_OF_DECLARE(imx50_timer, "fsl,imx50-gpt", imx31_timer_init_dt);
>
> I've tested it, and it works fine, now my apf27 (imx27) boot without any
> issue.
> So good catch, thanks a lot for this patch.

Excellent :-)

>
> I may send a patch on lkml if you want.

Yes, please submit a formal patch.

I thought it was imx1_timer_init_dt because in imx27.dtsi we have:

compatible = "fsl,imx27-gpt", "fsl,imx1-gpt";

So I am wondering if this is correct or it should be

compatible = "fsl,imx27-gpt", "fsl,imx21-gpt"; instead?

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/