linux-kernel - Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <op.x0wlcqiynngjn5@freezie>
Date:	Sat, 27 Jun 2015 22:20:40 +0300
From:	Роман Донченко 
	<dpb@...rigendum.ru>
To:	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	Toralf Förster <toralf.foerster@....de>
Subject: Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h

Toralf Förster <toralf.foerster@....de> писал в своём письме Sat, 27 Jun  
2015 22:16:27 +0300:

>> The casts are safe, since those conditions are only evaluated when sz  
>> >= 0.
>
>
> Wouldn't in this case the condition "sz < 0" be superfluously ?

No, sz can be negative. I meant that if sz < 0, then the second halves  
won't be evaluated (though even if they did, it wouldn't matter).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/