linux-kernel - Re: [PATCH] drivers: net: xgene: Pre-initialize ret in xgene_enet_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150628.165448.1251421470587728980.davem@davemloft.net>
Date:	Sun, 28 Jun 2015 16:54:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	stripathi@....com, isubramanian@....com, kchudgar@....com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: net: xgene: Pre-initialize ret in
 xgene_enet_get_resources()

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Thu, 25 Jun 2015 15:13:29 +0200

> If CONFIG_ACPI=n:
> 
>     drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function ‘xgene_enet_get_resources’:
>     drivers/net/ethernet/apm/xgene/xgene_enet_main.c:951: warning: ‘ret’ may be used uninitialized in this function
> 
> If the driver is bound to a legacy platform device, ret will contain
> arbitrary data. If it is non-zero, it will be returned to the caller as
> an error code.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied.