[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACh33Fr3ySyk7toDDAXiEQO5psOSw+qhomXeOtZ9zdnSU=Mq1g@mail.gmail.com>
Date: Sat, 27 Jun 2015 20:53:03 -0400
From: Patrick Donnelly <batrick@...bytes.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Jiri Slaby <jslaby@...e.cz>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Check tcsetpgrp p is a process group.
On Sat, Jun 27, 2015 at 7:26 PM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Sat, Jun 27, 2015 at 05:17:03PM -0400, Patrick Donnelly wrote:
>> This fixes a bug where a process can set the foreground process group to its
>> pid even if its pid is not a valid pgrp.
>>
>> Signed-off-by: Patrick Donnelly <batrick@...bytes.com>
>> ---
>> drivers/tty/tty_io.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
>> index 401d05e..c20a2fb 100644
>> --- a/drivers/tty/tty_io.c
>> +++ b/drivers/tty/tty_io.c
>> @@ -2560,9 +2560,11 @@ static int tiocspgrp(struct tty_struct *tty, struct tty_struct *real_tty, pid_t
>> {
>> struct pid *pgrp;
>> pid_t pgrp_nr;
>> - int retval = tty_check_change(real_tty);
>> + int retval;
>> unsigned long flags;
>>
>> + retval = tty_check_change(real_tty);
>
> Why this churn?
I removed it in the new version, sorry. I thought it made the code
more consistent.
--
Patrick Donnelly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists