linux-kernel - RE: [PATCH] scsi: storvsc: be more picky about scmnd->sc_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR0301MB16548730485D11B010D6C4F1A0AB0@BY2PR0301MB1654.namprd03.prod.outlook.com>
Date:	Sun, 28 Jun 2015 02:36:22 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:	Long Li <longli@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Radim Krčmář <rkrcmar@...hat.com>
Subject: RE: [PATCH] scsi: storvsc: be more picky about
 scmnd->sc_data_direction



> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Thursday, June 25, 2015 9:12 AM
> To: linux-scsi@...r.kernel.org
> Cc: Long Li; KY Srinivasan; Haiyang Zhang; James E.J. Bottomley;
> devel@...uxdriverproject.org; linux-kernel@...r.kernel.org; Radim Krčmář
> Subject: [PATCH] scsi: storvsc: be more picky about scmnd-
> >sc_data_direction
> 
> Under the 'default' case in scmnd->sc_data_direction we have 3 options:
> - DMA_NONE which we handle correctly.
> - DMA_BIDIRECTIONAL which is never supposed to be set by SCSI stack.
> - Garbage value.
> 
> Do WARN() and return -EINVAL in the last two cases. virtio_scsi does
> BUG_ON() here but it looks like an overkill.
> 
> Reported-by: Radim Krčmář <rkrcmar@...hat.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>  drivers/scsi/storvsc_drv.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3c6584f..61f4855 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1598,10 +1598,18 @@ static int storvsc_queuecommand(struct
> Scsi_Host *host, struct scsi_cmnd *scmnd)
>  		vm_srb->data_in = READ_TYPE;
>  		vm_srb->win8_extension.srb_flags |=
> SRB_FLAGS_DATA_IN;
>  		break;
> -	default:
> +	case DMA_NONE:
>  		vm_srb->data_in = UNKNOWN_TYPE;
>  		vm_srb->win8_extension.srb_flags |=
> SRB_FLAGS_NO_DATA_TRANSFER;
>  		break;
> +	default:
> +		/*
> +		 * This is DMA_BIDIRECTIONAL or something else we are
> never
> +		 * supposed to see here.
> +		 */
> +		WARN(1, "Unexpected data direction: %d\n",
> +		     scmnd->sc_data_direction);
> +		return -EINVAL;
>  	}
> 
> 
> --
> 2.4.3