linux-kernel - [PATCH RFC 3/5] kdbus: do explicit overflow check in kdbus_conn_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1435497454-10464-4-git-send-email-sergei@s15v.net>
Date:	Sun, 28 Jun 2015 16:17:32 +0300
From:	Sergei Zviagintsev <sergei@...v.net>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>
Cc:	linux-kernel@...r.kernel.org, Sergei Zviagintsev <sergei@...v.net>
Subject: [PATCH RFC 3/5] kdbus: do explicit overflow check in kdbus_conn_quota_inc()

Replace the use of max() with explicit and obvious overflow check.

Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
---
 ipc/kdbus/connection.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c
index af044f93c14f..1d44e280eff0 100644
--- a/ipc/kdbus/connection.c
+++ b/ipc/kdbus/connection.c
@@ -668,9 +668,11 @@ int kdbus_conn_quota_inc(struct kdbus_conn *c, struct kdbus_user *u,
 
 	id = u ? u->id : KDBUS_USER_KERNEL_ID;
 	if (id >= c->n_quota) {
-		unsigned int users;
+		unsigned int users = KDBUS_ALIGN8(id) + 8;
+
+		if (users < id) /* overflow */
+			users = id;
 
-		users = max(KDBUS_ALIGN8(id) + 8, id);
 		quota = krealloc(c->quota, users * sizeof(*quota),
 				 GFP_KERNEL | __GFP_ZERO);
 		if (!quota)
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/