linux-kernel - Re: Subject: [PATCH 1/2] staging : Comedi : comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55910FC7.1020506@mev.co.uk>
Date:	Mon, 29 Jun 2015 10:28:39 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Santhosh Pai <santhosh.pai88@...oo.com>, sudipm.mukherjee@...il.com
CC:	hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the
 return error, code

On 29/06/15 10:15, Ian Abbott wrote:
> On 27/06/15 06:36, Santhosh Pai wrote:
>>
>>  From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001
>> From: santhosh pai <santhosh.pai88@...oo.com>
>> Date: Mon, 22 Jun 2015 23:26:33 +0530
>> Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return
>> error
>>   code
>>
>>    try_module_get fails when the reference count of the module is not
>>    allowed to be incremented ,and hence -ENXIO is returned indicating
>>    no device or address.
>>
>> Signed-off-by: santhosh pai <santhosh.pai88@...oo.com>
>> ---
>>   drivers/staging/comedi/comedi_fops.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/comedi/comedi_fops.c
>> b/drivers/staging/comedi/comedi_fops.c
>> index d6a37e9..1ab443c 100644
>> --- a/drivers/staging/comedi/comedi_fops.c
>> +++ b/drivers/staging/comedi/comedi_fops.c
>> @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode,
>> struct file *file)
>>       }
>>       if (dev->attached && dev->use_count == 0) {
>>           if (!try_module_get(dev->driver->module)) {
>> -            rc = -EPERM;
>> +            rc = -ENXIO;
>>               goto out;
>>           }
>>           if (dev->open) {
>>
>
> The patch itself is okay, but all the stuff around the patch is a bit
> weird, such as:
>
> 1. all those email headers in the commit message
> 2. useless indentation in the commit message
> 3. subject line in commit message says "PATCH 2/2", but email subject
> line says "PATCH 1/2"
> 4. stray comma in email subject line
> 5. spaces before colon in subject lines

Actually, the patch doesn't apply, because it's on top of your other 
patch that changed -ENOSYS to -EPERM.

>
> This is taking too long, so I'll post a cleaned-up version.
>

I'll combine your two changes to the error return value into a single patch.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/