linux-kernel - Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150629100251.GZ7557@n2100.arm.linux.org.uk>
Date:	Mon, 29 Jun 2015 11:02:51 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	John Stultz <john.stultz@...aro.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi
 tracepoints

On Wed, Jun 24, 2015 at 01:14:18PM -0700, Stephen Boyd wrote:
> John Stultz reported an RCU splat on ARM with ipi trace events
> enabled. It looks like the same problem exists on ARM64.
> 
> At this point in the IPI handling path we haven't called
> irq_enter() yet, so RCU doesn't know that we're about to exit
> idle and properly warns that we're using RCU from an idle CPU.
> Use trace_ipi_entry_rcuidle() instead of trace_ipi_entry() so
> that RCU is informed about our exit from idle.
> 
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: Nicolas Pitre <nicolas.pitre@...aro.org>
> Fixes: 45ed695ac10a "ARM64: add IPI tracepoints"
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

I can find no trace of your equivalent ARM patch in my mailbox, but my
comment is as relevant to that message as it is to this one.

The Fixes: line has a standard format, which is not the formatting above.
Please see Documentation/SubmittingPatches section 2.  Thanks.

I've fixed it when applying the ARM version of this patch.  However, I'm
left wondering whether the lack of update to change the "Silence" to "Fix"
which I _stumbled_ over later in this thread is laziness on your part -
had it not been for the malformed Fixes: line, I would not have known to
update that.

We all gets lots of email every day, expecting people to remember some
comment in the dim and distant past made to a similar but different patch
is not really on.  Please ensure that you update your patches in future.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/