linux-kernel - Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150629135040.GW178524@redhat.com>
Date:	Mon, 29 Jun 2015 09:50:40 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Ravi Teja <ravi.teja@...libriumenergy.com>
Cc:	benjamin.romer@...sys.com, david.kershner@...sys.com,
	gregkh@...uxfoundation.com, jes.sorensen@...hat.com,
	sparmaintainer@...sys.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
> 
> This patch fixes checkpatch warnings
> 
> Signed-off-by: Ravi Teja Darbha <ravi2j@...il.com>

David,

Is this code removed after you ripped out the parahotplug stuff?
IOW, the next round of updates from Ben might obsolete this patch.

Cheers,
Don

> ---
>  drivers/staging/unisys/visorbus/visorchipset.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index bb8087e..62f7f68 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -1410,8 +1410,8 @@ visorchipset_chipset_ready(void)
>  static int
>  visorchipset_chipset_selftest(void)
>  {
> -    char env_selftest[20];
> -    char *envp[] = { env_selftest, NULL };
> +    static char env_selftest[20];
> +    static const char * const envp[] = { env_selftest, NULL };
>  
>      sprintf(env_selftest, "SPARSP_SELFTEST=%d", 1);
>      kobject_uevent_env(&visorchipset_platform_device.dev.kobj, KOBJ_CHANGE,
> @@ -1559,9 +1559,9 @@ static void
>  parahotplug_request_kickoff(struct parahotplug_request *req)
>  {
>      struct controlvm_message_packet *cmd = &req->msg.cmd;
> -    char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40],
> -        env_func[40];
> -    char *envp[] = {
> +    static char env_cmd[40], env_id[40], env_state[40], env_bus[40],
> +            env_dev[40], env_func[40];
> +    static const char * const envp[] = {
>          env_cmd, env_id, env_state, env_bus, env_dev, env_func, NULL
>      };
>  
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/