linux-kernel - RE: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7CFCFE83B8145347A1D424EC939F1C3CA763F3@XAP-PVEXMBX01.xlnx.xilinx.com>
Date:	Mon, 29 Jun 2015 06:00:08 +0000
From:	Ranjit Abhimanyu Waghmode <ranjit.waghmode@...inx.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Mark Brown <broonie@...nel.org>,
	Michal Simek <michals@...inx.com>,
	Soren Brinkmann <sorenb@...inx.com>
CC:	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA

Acked-by: Ranjit Waghmode <ranjitw@...inx.com>

> -----Original Message-----
> From: Geert Uytterhoeven [mailto:geert@...ux-m68k.org]
> Sent: Friday, June 26, 2015 5:37 PM
> To: Mark Brown; Ranjit Abhimanyu Waghmode
> Cc: linux-spi@...r.kernel.org; linux-kernel@...r.kernel.org; Geert
> Uytterhoeven
> Subject: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA
>
> If NO_DMA=y:
>
>     ERROR: "dma_unmap_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
>     ERROR: "dma_map_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/spi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index
> 1c0b261b66fcfdcb..b787b515bd73322b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -618,7 +618,7 @@ config SPI_XTENSA_XTFPGA
>
>  config SPI_ZYNQMP_GQSPI
>       tristate "Xilinx ZynqMP GQSPI controller"
> -     depends on SPI_MASTER
> +     depends on SPI_MASTER && HAS_DMA
>       help
>         Enables Xilinx GQSPI controller driver for Zynq UltraScale+ MPSoC.
>
> --
> 1.9.1



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/