lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Jun 2015 11:28:05 -0400 From: Tejun Heo <tj@...nel.org> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: pmladek@...e.cz, Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller" <davem@...emloft.net>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Kay Sievers <kay@...y.org>, Josh Triplett <josh@...htriplett.org>, Linux Embedded <linux-embedded@...r.kernel.org> Subject: Re: [PATCH 3/3] printk: implement support for extended console drivers Hello, On Mon, Jun 29, 2015 at 11:20:41AM +0200, Geert Uytterhoeven wrote: > On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo <tj@...nel.org> wrote: > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > > @@ -2196,6 +2227,7 @@ out: > > */ > > void console_unlock(void) > > { > > + static char ext_text[CONSOLE_EXT_LOG_MAX]; > > Can you please > a) make this feature optional, netconsole itself is optional & modular. I'm not sure making further splits is called for, especially given the use cases. > b) (de)allocate this buffer dynamically when the first/last console with > CON_EXTENDED set is (un)registered? But yeah, making the buffer allocated on demand should be simple enough. Will get to it. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists