linux-kernel - Re: [PATCH] ARM: BCM: Enable NAND support for iProc SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5591746A.80300@broadcom.com>
Date:	Mon, 29 Jun 2015 09:38:02 -0700
From:	Ray Jui <rjui@...adcom.com>
To:	Florian Fainelli <f.fainelli@...il.com>,
	Scott Branden <sbranden@...adcom.com>,
	Russell King <linux@....linux.org.uk>
CC:	<linux-kernel@...r.kernel.org>,
	<bcm-kernel-feedback-list@...adcom.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: BCM: Enable NAND support for iProc SoCs

Hi Florian,

On 6/26/2015 1:55 PM, Florian Fainelli wrote:
> On 28/05/15 18:09, Ray Jui wrote:
>> Select CONFIG_MTD_NAND_BRCMNAND for all iProc SoCs
> 
> In fact, this patch creates an unmet dependency problem, we also need to
> select MTD and MTD_NAND otherwise we run into a linking error while
> building the brcmnand driver:
> 
>   LD      init/built-in.o
> drivers/built-in.o: In function `brcmnand_remove':
> /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:2234:
> undefined reference to `nand_release'
> drivers/built-in.o: In function `brcmnand_init_cs':
> /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:1933:
> undefined reference to `nand_scan_ident'
> /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:1958:
> undefined reference to `nand_scan_tail'
> Makefile:931: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> I will take care of that and send a fix for 4.2.
> 

When I tested this, I tested against multi_v7_defconfig where MTD and
MTD_NAND were enabled in the defconfig, so I did not see this problem.

Thanks a lot for helping to fix this.

Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/