linux-kernel - Re: [PATCH] fs/file.c: __fget() and dup2() atomicity rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2015 18:46:16 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs/file.c: __fget() and dup2() atomicity rules

On Mon, Jun 29, 2015 at 05:10:30PM +0200, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> __fget() makes sure a file refcount is not zero before
> taking a reference. It should also fetch again file pointer
> in order to respect dup2() atomicity requirements.
> 
> It should either read a NULL pointer or a file on which
> a refcount can be taken.

Hmm...   The problem is real, but I wonder if one could trigger a long
spin there...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/