linux-kernel - Re: [PATCH v4 2/2] TPM: remove unnecessary little endian conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2015 14:52:41 -0400
From:	"Hon Ching(Vicky) Lo" <honclo@...ux.vnet.ibm.com>
To:	tpmdd-devel@...ts.sourceforge.net
Cc:	Peter Huewe <PeterHuewe@....de>, Ashley Lai <ashley@...leylai.com>,
	Vicky Lo <honclo2014@...il.com>, linux-kernel@...r.kernel.org,
	Joy Latten <jmlatten@...ux.vnet.ibm.com>
Subject: Re: [PATCH v4 2/2] TPM: remove unnecessary little endian conversion

Hi Peter,

Please also commit this patch, if you accept it as well.


Thanks,
Vicky

-------- Forwarded Message --------
From: Ashley Lai <ashley@...leylai.com>
To: Hon Ching(Vicky) Lo <honclo@...ux.vnet.ibm.com>
Cc: tpmdd-devel@...ts.sourceforge.net, Peter Huewe <PeterHuewe@....de>,
Ashley Lai <ashley@...leylai.com>, Vicky Lo <honclo2014@...il.com>,
linux-kernel@...r.kernel.org, Joy Latten <jmlatten@...ux.vnet.ibm.com>
>Subject: Re: [PATCH v4 2/2] TPM: remove unnecessary little endian
conversion
> Date: Thu, 18 Jun 2015 08:23:33 -0500 (CDT)

> Looks good.

> Reviewed-by: Ashley Lai <ashley@...leylai.com>

> Ashley Lai


On Wed, 2015-06-17 at 18:17 -0400, Hon Ching(Vicky) Lo wrote:
> The base pointer for the event log is allocated in the local
> kernel (in prom_instantiate_sml()), therefore it is already in
> the host's endian byte order and requires no conversion.
> 
> The content of the 'basep' pointer in read_log() stores the
> base address of the log. This patch ensures that it is correctly
> implemented.
> 
> Signed-off-by: Hon Ching(Vicky) Lo <honclo@...ux.vnet.ibm.com>
> Signed-off-by: Joy Latten <jmlatten@...ux.vnet.ibm.com>
> ---
>  drivers/char/tpm/tpm_of.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
> index c002d1b..62a22ce 100644
> --- a/drivers/char/tpm/tpm_of.c
> +++ b/drivers/char/tpm/tpm_of.c
> @@ -24,7 +24,7 @@ int read_log(struct tpm_bios_log *log)
>  {
>  	struct device_node *np;
>  	const u32 *sizep;
> -	const __be64 *basep;
> +	const u64 *basep;
> 
>  	if (log->bios_event_log != NULL) {
>  		pr_err("%s: ERROR - Eventlog already initialized\n", __func__);
> @@ -63,7 +63,7 @@ int read_log(struct tpm_bios_log *log)
> 
>  	log->bios_event_log_end = log->bios_event_log + *sizep;
> 
> -	memcpy(log->bios_event_log, __va(be64_to_cpup(basep)), *sizep);
> +	memcpy(log->bios_event_log, __va(*basep), *sizep);
> 
>  	return 0;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/