linux-kernel - Re: [tip:irq/urgent] pinctrl/st: Fix race in installing chained IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5590EEE2.7080205@st.com>
Date:	Mon, 29 Jun 2015 09:08:18 +0200
From:	Patrice Chotard <patrice.chotard@...com>
To:	<tglx@...utronix.de>, <hpa@...or.com>, <Julia.Lawall@...6.fr>,
	<rmk+kernel@....linux.org.uk>, <mingo@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linus.walleij@...aro.org>,
	<srinivas.kandagatla@...il.com>, <maxime.coquelin@...com>,
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:irq/urgent] pinctrl/st: Fix race in installing chained IRQ
 handler

Hi Thomas

On 06/26/2015 09:45 PM, tip-bot for Thomas Gleixner wrote:
> Commit-ID:  1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0
> Gitweb:     http://git.kernel.org/tip/1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0
> Author:     Thomas Gleixner <tglx@...utronix.de>
> AuthorDate: Sun, 21 Jun 2015 20:16:15 +0200
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Thu, 25 Jun 2015 11:57:09 +0200
>
> pinctrl/st: Fix race in installing chained IRQ handler
>
> Fix a race where a pending interrupt could be received and the handler
> called before the handler's data has been setup, by converting to
> irq_set_chained_handler_and_data().
>
> Search and conversion was done with coccinelle:
>
> @@
> expression E1, E2, E3;
> @@
> (
> -if (irq_set_chained_handler(E1, E3) != 0)
> -   BUG();
> |
> -irq_set_chained_handler(E1, E3);
> )
> -irq_set_handler_data(E1, E2);
> +irq_set_chained_handler_and_data(E1, E3, E2);
>
> @@
> expression E1, E2, E3;
> @@
> (
> -if (irq_set_chained_handler(E1, E3) != 0)
> -   BUG();
> ...
> |
> -irq_set_chained_handler(E1, E3);
> ...
> )
> -irq_set_handler_data(E1, E2);
> +irq_set_chained_handler_and_data(E1, E3, E2);
>
> Reported-by: Russell King <rmk+kernel@....linux.org.uk>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Julia Lawall <Julia.Lawall@...6.fr>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...il.com>
> Cc: Maxime Coquelin <maxime.coquelin@...com>
> Cc: Patrice Chotard <patrice.chotard@...com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: kernel@...inux.com
> Cc: linux-gpio@...r.kernel.org
> ---
>   drivers/pinctrl/pinctrl-st.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 65bf73b..10e9c4e8 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1661,8 +1661,8 @@ static int st_pctl_probe_dt(struct platform_device *pdev,
>   		if (IS_ERR(info->irqmux_base))
>   			return PTR_ERR(info->irqmux_base);
>   
> -		irq_set_chained_handler(irq, st_gpio_irqmux_handler);
> -		irq_set_handler_data(irq, info);
> +		irq_set_chained_handler_and_data(irq, st_gpio_irqmux_handler,
> +						 info);
>   
>   	}

Acked-by: Patrice Chotard <patrice.chotard@...com>

Thanks
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/